fix: social history conversion #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmcgrath13
changed the title
1 task
mcmcgrath13
changed the title
…into mcm/fix-social-history-obs
mcmcgrath13
requested review from
BobanL,
angelathe and
austin-hall-skylight
BobanL
approved these changes
Nov 14, 2024
Comment on lines
+140
to
+141
| {% include 'Section/SocialHistory' SOCIALOBS: socialObs SOCIALTEXT: socialHistoryText -%} | ||
| {% include 'Resource/Patient' patientRole: msg.ClinicalDocument.recordTarget.patientRole ID: patientId SOCIALOBS: socialObs SOCIALTEXT: socialHistoryText contact: msg.ClinicalDocument.participant.associatedEntity -%} |
There was a problem hiding this comment.
socialHistoryText isn't defined yet right? So is the point of passing the blank socialHistoryText to Section/SocialHistory to give it a value that can be used in Resource/Patient?
There was a problem hiding this comment.
yeah, it's a weird hack that takes advantage of leaky variable scopes 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turned a little meandering - apologies.
nullFlavor = UNKto still be converted as long as they have original text in their value fieldUtil/IsSocialHistoryObservationtemplate.capturethis result when including the template in another template and use its value to simplify/dry out the code therecase/whento dry out a lot of repeated template ID-ing (and also add the check to look at the first as sometimes this had more than one thing and then the old logic just wasn't hitting 😬 )SOCIALOBSin the social history_entry.liquidand just make it a normal special case as it wasn't needed and was causing weird merged objects because we were also converting it in the regular way.value[x]fhir mappings and use it in a lot of places